Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OpenTelemetry support for Subscribe Side #1252

Merged
merged 56 commits into from
Sep 24, 2024

Conversation

mukund-ananthu
Copy link
Contributor

@mukund-ananthu mukund-ananthu commented Sep 16, 2024

Subscribe Side OpenTelemetry Code

@mukund-ananthu mukund-ananthu requested review from a team as code owners September 16, 2024 20:42
Copy link

conventional-commit-lint-gcf bot commented Sep 16, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium. size: l Pull request size is large. and removed size: s Pull request size is small. size: m Pull request size is medium. labels Sep 16, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. size: l Pull request size is large. and removed size: l Pull request size is large. size: m Pull request size is medium. labels Sep 18, 2024
@mukund-ananthu mukund-ananthu force-pushed the otel_subscribe_feature branch 2 times, most recently from 6deb637 to 1703dd2 Compare September 18, 2024 19:29
* Both these methods should add the "ack start" event to the subscribe
  span
* Both these methods should add "nack start" events to the subscribe
  span
* Both these methods should add the "modack start" event to the
  subscribe span
* Currently, subscribe_span is ended after modack end event is added to
  the subscribe_span. This should not happen, since subscribe_span
  should be ended only after ack,nack or drop, but not modack
* Remove an extraneous modack start that was present in
  streaming_pull_manager.send_lease_modacks(). This is not required,
  since modack start and end events will anyways be added to the
  subscribe span in the dispatcher.modify_ack_deadline() method.
* Replace the NamedTuple._replace() methods with creation of new
  NamedTuple ModackRequest items. This is because NamedTuple._replace()
  returns a new NamedTuple, rather than replacing the existing one. This
  results in the opentelemetry data not being plumbed down into the
  dispatcher.modify_ack_deadline_method.
@mukund-ananthu
Copy link
Contributor Author

@hongalex PTAL

@mukund-ananthu
Copy link
Contributor Author

@parthea PTAL

@mukund-ananthu mukund-ananthu merged commit 1b6f3d2 into main Sep 24, 2024
26 of 27 checks passed
@mukund-ananthu mukund-ananthu deleted the otel_subscribe_feature branch September 24, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants